Initial implementation #1
Conversation
Mordil
force-pushed
the
initial-implementation
branch
from
a7b9b9d
to
9305ed4
Compare
Mordil
force-pushed
the
initial-implementation
branch
from
9305ed4
to
2e91195
Compare
Sources/Currency/Money.swift
Outdated
| /// | ||
| /// See `CurrencyMetadata.minorUnits` and `Foundation.Decimal.RoundingMode.bankers`. | ||
| /// - Note: This is usually the desired value to work with, as it is as precise as usually needed. | ||
| var amount: Decimal { get } |
There was a problem hiding this comment.
rawAmount is not super meaningful. What we call Amount here is not the actual amount but the rounded value.
To be more explicit, should we have:
rawAmount => amount
amount=> roundedAmount or rounded
There was a problem hiding this comment.
I actually had that original naming, but towards the end I moved to the current naming - as my concern is many people would use amount when they really want roundedAmount. 99% of the time, people want the every day banker's rounded value.
How do you feel about:
amount => roundedAmount
rawAmount => exactAmount
Sources/Currency/Money.swift
Outdated
| /// To get around this, the provided `other` amount will be rounded to the same precision as the `minorUnits` of the Money's currency using the "banker" mode. | ||
| /// | ||
| /// See `Money.amount`. | ||
| /// - Parameter other: The other amount to "bankers' round, then compare against. |
There was a problem hiding this comment.
The parameter description kind of implies that we should pass other as the rounded amount. Where we should actually pass the actual amount.
There was a problem hiding this comment.
That's a reasonable misunderstanding - I'll clarify this section.
No description provided.