-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sendMessage with quoted message id #3260
Merged
alechkos
merged 5 commits into
pedroslopez:main
from
alwinlubbers:fix-sendmessage-quotedmessageid
Sep 14, 2024
Merged
fix: sendMessage with quoted message id #3260
alechkos
merged 5 commits into
pedroslopez:main
from
alwinlubbers:fix-sendmessage-quotedmessageid
Sep 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using `window.Store.Msg.getMessagesById` instead of `window.Store.Msg.get`
shirser121
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
BothimTV
approved these changes
Sep 8, 2024
Jlam9
approved these changes
Sep 13, 2024
Hi there! Just checking in, do you have any idea when this PR might be merged? |
@alechkos @tuyuribr @tuyuribr3 you should approve this |
alechkos
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using
window.Store.Msg.getMessagesById
instead ofwindow.Store.Msg.get
PR Details
This PR fixes the exception that was thrown when using
client.sendMessage()
with aquotedMessageId
in theMessageSendOptions
parameter.Description
It seemed like
window.Store.get()
couldn't get a message, even with a valid serialized chat message id.The
window.Store.Msg.getMessagesById
function was taken from here:whatsapp-web.js/src/Client.js
Line 1039 in 066d8fa
Related Issue
closes #3259
Motivation and Context
This will solve the problem of being unable to send messages with a quote attached.
How Has This Been Tested
I've tested this version with my local Node.js install (system/os details can be found in the mentioned issue).
I've tried sending a couple of messages in private and group chats. With both messages from me and others. It has also been tested on a clean install (without auth).
Types of changes
Checklist