Do not store RealmModel in cache entries

Closes keycloak#33439 Signed-off-by: Pedro Igor <[email protected]>
pedroigor · Oct 1, 2024 · 31391a7 · 31391a7
1 parent 5218af1
commit 31391a7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/...nispan/src/main/java/org/keycloak/models/cache/infinispan/idp/CachedIdentityProvider.java b/...nispan/src/main/java/org/keycloak/models/cache/infinispan/idp/CachedIdentityProvider.java
@@ -23,18 +23,18 @@
 
 public class CachedIdentityProvider extends AbstractRevisioned implements InRealm {
 
-    private final RealmModel realm;
+    private final String realm;
     private final IdentityProviderModel idp;
 
     public CachedIdentityProvider(Long revision, RealmModel realm, String cacheKey, IdentityProviderModel idp) {
         super(revision, cacheKey);
-        this.realm = realm;
+        this.realm = realm.getId();
         this.idp = idp;
     }
 
     @Override
     public String getRealm() {
-        return realm.getId();
+        return realm;
     }
 
     public IdentityProviderModel getIdentityProvider() {

diff --git a/.../src/main/java/org/keycloak/models/cache/infinispan/idp/CachedIdentityProviderMapper.java b/.../src/main/java/org/keycloak/models/cache/infinispan/idp/CachedIdentityProviderMapper.java
@@ -23,18 +23,18 @@
 
 public class CachedIdentityProviderMapper extends AbstractRevisioned implements InRealm {
 
-    private final RealmModel realm;
+    private final String realm;
     private final IdentityProviderMapperModel mapper;
 
     public CachedIdentityProviderMapper(Long revision, RealmModel realm, String cacheKey, IdentityProviderMapperModel mapper) {
         super(revision, cacheKey);
-        this.realm = realm;
+        this.realm = realm.getId();
         this.mapper = mapper;
     }
 
     @Override
     public String getRealm() {
-        return realm.getId();
+        return realm;
     }
 
     public IdentityProviderMapperModel getIdentityProviderMapper() {

diff --git a/...n/src/main/java/org/keycloak/models/cache/infinispan/organization/CachedOrganization.java b/...n/src/main/java/org/keycloak/models/cache/infinispan/organization/CachedOrganization.java
@@ -32,7 +32,7 @@
 
 public class CachedOrganization extends AbstractRevisioned implements InRealm {
 
-    private final RealmModel realm;
+    private final String realm;
     private final String name;
     private final String alias;
     private final String description;
@@ -43,7 +43,7 @@ public class CachedOrganization extends AbstractRevisioned implements InRealm {
 
     public CachedOrganization(Long revision, RealmModel realm, OrganizationModel organization) {
         super(revision, organization.getId());
-        this.realm = realm;
+        this.realm = realm.getId();
         this.name = organization.getName();
         this.alias = organization.getAlias();
         this.description = organization.getDescription();
@@ -55,10 +55,10 @@ public CachedOrganization(Long revision, RealmModel realm, OrganizationModel org
 
     @Override
     public String getRealm() {
-        return realm.getId();
+        return realm;
     }
 
-    public RealmModel getRealmModel() {
+    public String getRealmModel() {
         return realm;
     }