Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic timing information #278

Merged
merged 1 commit into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 52 additions & 22 deletions src/loMach.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ void LoMachSolver::initialize() {
bool verbose = rank0_;
if (verbose) grvy_printf(ginfo, "Initializing loMach solver.\n");

sw_setup_.Start();

// Stash the order, just for convenience
order = loMach_opts_.order;

Expand Down Expand Up @@ -289,6 +291,8 @@ void LoMachSolver::initialize() {
sponge_->initializeViz(*pvdc_);
extData_->initializeViz(*pvdc_);
average_->initializeViz();

sw_setup_.Stop();
}

void LoMachSolver::UpdateTimestepHistory(double dt) {
Expand Down Expand Up @@ -374,28 +378,34 @@ void LoMachSolver::solveBegin() {
}

void LoMachSolver::solveStep() {
sw_step.Start();
sw_step_.Start();

if (loMach_opts_.ts_opts_.integrator_type_ == LoMachTemporalOptions::CURL_CURL) {
SetTimeIntegrationCoefficients(iter - iter_start_);
extData_->step();
sw_thermChem_.Start();
thermo_->step();
sw_thermChem_.Stop();
sw_flow_.Start();
flow_->step();
sw_flow_.Stop();
sw_turb_.Start();
turbModel_->step();
sw_turb_.Stop();
} else {
if (rank0_) std::cout << "Time integration not updated." << endl;
exit(1);
}
sw_step.Stop();
sw_step_.Stop();

UpdateTimestepHistory(temporal_coeff_.dt);
temporal_coeff_.time += temporal_coeff_.dt;
temporal_coeff_.nStep = iter;
iter++;

if ((iter % loMach_opts_.timing_frequency_) == 0) {
double time_per_step = (sw_step.RealTime() - tlast_) / loMach_opts_.timing_frequency_;
tlast_ = sw_step.RealTime();
double time_per_step = (sw_step_.RealTime() - tlast_) / loMach_opts_.timing_frequency_;
tlast_ = sw_step_.RealTime();

double max_time_per_step = 0.0;
MPI_Reduce(&time_per_step, &max_time_per_step, 1, MPI_DOUBLE, MPI_MAX, 0, groupsMPI->getTPSCommWorld());
Expand Down Expand Up @@ -477,6 +487,9 @@ void LoMachSolver::solveEnd() {
average_->writeViz(iter, temporal_coeff_.time, avg_opts_->save_mean_history_);
MPI_Barrier(groupsMPI->getTPSCommWorld());
if (rank0_ == true) std::cout << " ...complete!" << endl;

// timing information
PrintTimingData();
}

void LoMachSolver::solve() {
Expand Down Expand Up @@ -739,24 +752,6 @@ void LoMachSolver::SetTimeIntegrationCoefficients(int step) {
}
}

void LoMachSolver::PrintTimingData() {
double my_rt[2], rt_max[2];

my_rt[0] = sw_setup.RealTime();
my_rt[1] = sw_step.RealTime();

MPI_Reduce(my_rt, rt_max, 2, MPI_DOUBLE, MPI_MAX, 0, pmesh_->GetComm());

if (pmesh_->GetMyRank() == 0) {
mfem::out << std::setw(10) << "SETUP" << std::setw(10) << "STEP"
<< "\n";

mfem::out << std::setprecision(3) << std::setw(10) << my_rt[0] << std::setw(10) << my_rt[1] << "\n";

mfem::out << std::setprecision(8);
}
}

// query solver-specific runtime controls
void LoMachSolver::parseSolverOptions() {
// if (verbose) grvy_printf(ginfo, "parsing solver options...\n");
Expand Down Expand Up @@ -823,3 +818,38 @@ void LoMachSolver::parseSolverOptions() {
loMach_opts_.compute_wallDistance = true;
}
}

void LoMachSolver::PrintTimingData() {
double my_rt[7], rt_max[7];
my_rt[0] = sw_setup_.RealTime();
my_rt[1] = sw_step_.RealTime();
my_rt[2] = sw_turb_.RealTime();
my_rt[3] = sw_thermChem_.RealTime();
my_rt[4] = sw_flow_.RealTime();
my_rt[5] = flow_->getPressureSolveTimer();
my_rt[6] = flow_->getHelmholtzSolveTimer();

double dIters;
dIters = (double)(loMach_opts_.max_steps_ - iter_start_);

MPI_Reduce(my_rt, rt_max, 7, MPI_DOUBLE, MPI_MAX, 0, pmesh_->GetComm());

if (rank0_) {
mfem::out << "\n";
mfem::out << "TIMING REPORT. (sec/step and fraction of step) \n";
mfem::out << std::setw(10) << "SETUP" << std::setw(10) << "STEP" << std::setw(15) << "TURB-MODEL" << std::setw(15)
<< "THERM-CHEM" << std::setw(10) << "FLOW:" << std::setw(12) << "PSOLVE" << std::setw(12) << "HSOLVE"
<< "\n";

mfem::out << std::setprecision(5) << std::setw(10) << my_rt[0] / dIters << std::setw(10) << my_rt[1] / dIters
<< std::setw(15) << my_rt[2] / dIters << std::setw(15) << my_rt[3] / dIters << std::setw(10)
<< my_rt[4] / dIters << std::setw(12) << my_rt[5] / dIters << std::setw(12) << my_rt[6] / dIters << "\n";

mfem::out << std::setprecision(5) << std::setw(10) << " " << std::setw(10) << my_rt[1] / my_rt[1] << std::setw(15)
<< my_rt[2] / my_rt[1] << std::setw(15) << my_rt[3] / my_rt[1] << std::setw(10) << my_rt[4] / my_rt[1]
<< std::setw(12) << my_rt[5] / my_rt[1] << std::setw(12) << my_rt[6] / my_rt[1] << "\n";

mfem::out << std::setprecision(8);
mfem::out << "\n";
}
}
2 changes: 1 addition & 1 deletion src/loMach.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class LoMachSolver : public TPS::PlasmaSolver {
int order;

// Timers.
StopWatch sw_setup, sw_step;
StopWatch sw_setup_, sw_step_, sw_turb_, sw_thermChem_, sw_flow_, sw_press_;
double tlast_;

// I/O helpers
Expand Down
4 changes: 4 additions & 0 deletions src/split_flow_base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ class FlowBase {
* cases where we have an exact solution.
*/
virtual double computeL2Error() const { return -1.0; }

/// Get timing
virtual double getPressureSolveTimer() { return -1.0; }
virtual double getHelmholtzSolveTimer() { return -1.0; }
};

class ZeroFlow final : public FlowBase {
Expand Down
6 changes: 6 additions & 0 deletions src/tomboulides.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1117,6 +1117,7 @@ void Tomboulides::step() {

// Update the variable coefficient Laplacian to account for change
// in density
sw_press_.Start();
L_iorho_form_->Update();
L_iorho_form_->Assemble();
L_iorho_form_->FormSystemMatrix(pres_ess_tdof_, L_iorho_op_);
Expand Down Expand Up @@ -1146,6 +1147,7 @@ void Tomboulides::step() {
L_iorho_inv_->SetRelTol(pressure_solve_rtol_);
L_iorho_inv_->SetAbsTol(pressure_solve_atol_);
L_iorho_inv_->SetMaxIter(pressure_solve_max_iter_);
sw_press_.Stop();

// Update density weighted mass
Array<int> empty;
Expand All @@ -1156,6 +1158,7 @@ void Tomboulides::step() {
Mv_rho_inv_->SetOperator(*Mv_rho_op_);

// Update the Helmholtz operator and inverse
sw_helm_.Start();
Hv_bdfcoeff_.constant = coeff_.bd0 / dt;
Hv_form_->Update();
Hv_form_->Assemble();
Expand All @@ -1166,6 +1169,7 @@ void Tomboulides::step() {
// TODO(trevilo): Support partial assembly
assert(false);
}
sw_helm_.Stop();

//------------------------------------------------------------------------
// Step 2: Compute vstar / dt (as in eqn 2.3 from Tomboulides)
Expand Down Expand Up @@ -1355,6 +1359,7 @@ void Tomboulides::step() {
resp_vec_.Add(-coeff_.bd0 / dt, u_bdr_vec_);

// Orthogonalize rhs if no Dirichlet BCs on pressure
sw_press_.Start();
if (pres_dbcs_.empty()) {
Orthogonalize(resp_vec_, pfes_);
}
Expand All @@ -1381,6 +1386,7 @@ void Tomboulides::step() {
if (rank0_) std::cout << "ERROR: Poisson solve did not converge." << std::endl;
exit(1);
}
sw_press_.Stop();

// iter_spsolve = SpInv->GetNumIterations();
// res_spsolve = SpInv->GetFinalNorm();
Expand Down
6 changes: 6 additions & 0 deletions src/tomboulides.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ class Tomboulides final : public FlowBase {
// reference here.
const temporalSchemeCoefficients &coeff_;

StopWatch sw_press_, sw_helm_;

std::string ic_string_;

// Object used to build forcing
Expand Down Expand Up @@ -378,6 +380,10 @@ class Tomboulides final : public FlowBase {
/// Evaluate error (only when exact solution is known)
double computeL2Error() const final;

/// Get timings
double getPressureSolveTimer() { return sw_press_.RealTime(); }
double getHelmholtzSolveTimer() { return sw_helm_.RealTime(); }

/// Add a Dirichlet boundary condition to the velocity field
void addVelDirichletBC(const mfem::Vector &u, mfem::Array<int> &attr);
void addVelDirichletBC(mfem::VectorCoefficient *coeff, mfem::Array<int> &attr);
Expand Down
Loading