Avoid unnecessary matrix update

Specifically in chemistry substepping, avoid reevaluating the density-weighted mass matrix b/c it is not needed.
pecos · Dec 5, 2024 · 8e99343 · 8e99343
1 parent bdaa23d
commit 8e99343
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/reactingFlow.cpp b/src/reactingFlow.cpp
@@ -1608,7 +1608,7 @@ void ReactingFlow::step() {
       // update wdot quantities at full substep in Yn/Tn state
       updateMixture();
       updateThermoP();
-      updateDensity(0.0);
+      updateDensity(0.0, false);
       speciesProduction();
       heatOfFormation();
 
@@ -2503,7 +2503,7 @@ void ReactingFlow::evaluatePlasmaConductivityGF() {
   sigma_gf_.SetFromTrueDofs(sigma_);
 }
 
-void ReactingFlow::updateDensity(double tStep) {
+void ReactingFlow::updateDensity(double tStep, bool update_mass_matrix) {
   Array<int> empty;
   Rmix_gf_.GetTrueDofs(tmpR0a_);
 
@@ -2541,9 +2541,11 @@ void ReactingFlow::updateDensity(double tStep) {
   }
   rn_gf_.SetFromTrueDofs(rn_);
 
-  MsRho_form_->Update();
-  MsRho_form_->Assemble();
-  MsRho_form_->FormSystemMatrix(empty, MsRho_);
+  if (update_mass_matrix) {
+    MsRho_form_->Update();
+    MsRho_form_->Assemble();
+    MsRho_form_->FormSystemMatrix(empty, MsRho_);
+  }
 
   // project to p-space in case not same as vel-temp
   R0PM0_gf_.SetFromTrueDofs(rn_);

diff --git a/src/reactingFlow.hpp b/src/reactingFlow.hpp
@@ -366,7 +366,7 @@ class ReactingFlow : public ThermoChemModelBase {
   void updateMixture();
   void updateThermoP();
   void extrapolateState();
-  void updateDensity(double tStep);
+  void updateDensity(double tStep, bool update_mass_matrix = true);
   void updateBC(int current_step);
   void updateDiffusivity();
   void computeSystemMass();