Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In scope of PHP8.1 compatibility static analysis it was discovered some deprecations in webflo/drupal-finder codebase: line 222 vendor/pear/pear-core-minimal/src/PEAR.php get_class() without argument (tag 1.10.11) line 235 vendor/pear/pear-core-minimal/src/PEAR.php get_class() without argument (tag 1.10.11)
- Loading branch information
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this breaks compatibility with PHP 5.4. Any chance to have this back? Also, I suppose composer.json should specify minimum PHP version.
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimum PHP version is a good idea.
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this change didn't happen in https://github.com/pear/pear-core. Shouldn't both be in sync?
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should, but nobody cares enough anymore.
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background story how it is a problem for us.
Roundcube 1.4 is a few years old release that includes composer dependencies including pear-core-minimal. It is supposed to work on PHP >= 5.4. We set that requirement in the composer.json file. Because of a security issue we had to release an update. When we do that we run composer to get dependencies. It included recent pear-core-minimal package that is not compatible with PHP 5.4 anymore.
It went unnoticed by us because we do not have CI for this old branch. Also composer didn't complain because there's no min php version specified for pear-core-minimal. But our users noticed ;).
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alecpl shoot in a PR (probably best to set the composer min version) and we'll land it fairly quickly.
aed862e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alecpl got this fixed now in v1.10.22. Also added explicit >=5.4 in both
composer.json
files now.