Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 32-bit #30

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix for 32-bit #30

merged 2 commits into from
Jan 10, 2024

Conversation

remicollet
Copy link
Contributor

Else float will be used and and break type hinting

Test suite failing with

Fatal error: Uncaught TypeError: Cannot assign float to property Log::$mask of type int in /builddir/build/BUILDROOT/php-pear-Log-1.14.0-1.fc39.noarch/usr/share/pear/Log.php:147

See https://kojipkgs.fedoraproject.org//work/tasks/1602/111561602/build.log

remicollet and others added 2 commits January 10, 2024 10:08
@remicollet
Fix for 32-bit
5c6bd26 
Else float will be used and and break type hinting
@remicollet
fix test
9543bb2
@remicollet
Copy link
Contributor Author

Alternative solution is to use -1 which is all bits set on both 32-bit (0xffffffff) and 64-bit arch (0xffffffffffffffff)

jparise
jparise approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jparise jparise merged commit a796f91 into pear:master Jan 10, 2024
5 checks passed
@jparise
Copy link
Member

jparise commented Jan 10, 2024

This fix has been released as version 1.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @jparise