Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 1.14.0 release #29

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Prepare the 1.14.0 release #29

merged 1 commit into from
Jan 9, 2024

Conversation

jparise
Copy link
Member

@jparise jparise commented Jan 9, 2024

No description provided.

@jparise
Copy link
Member Author

jparise commented Jan 9, 2024

@sveneld how does this look to you?

I would normally bump the major package version, but that implies an entirely new package ("Log2") in PEAR world, and I don't know if that's strictly necessary given that the api version has been bumped to indicate changes to the protected interfaces.

@sveneld
Copy link
Contributor

sveneld commented Jan 9, 2024

I made a refactoring based on phpdoc, in which access levels to functions and properties was described. If someone used internal functions I can not be responsible for such use. Public api was not changed, it just become more typed, what gives more predictable behavior of this package. So maybe if information about php version change and about more strict typing will be written in release it will be enough.

@jparise jparise merged commit 72c63e0 into master Jan 9, 2024
5 checks passed
@jparise jparise deleted the package-1.14.0 branch January 9, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants