fix: check tokentype in validateLinkDetails #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Live tests failed. Please check the logs to see which checks failed. |
|
Live tests failed. Please check the logs to see which checks failed. |
Hugo0
approved these changes
Apr 22, 2024
| }) | ||
| if ( | ||
| linkDetails.tokenType == interfaces.EPeanutLinkType.erc20 || | ||
| linkDetails.tokenType == interfaces.EPeanutLinkType.native || |
There was a problem hiding this comment.
getTokenContractDetails should be renamed to getTokenDetails
There was a problem hiding this comment.
What's the point of the triple type check?
|
Live tests failed. Please check the logs to see which checks failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the check to fetch the tokenType/decimals. Previously, it would check if either the decimals or tokenType were undefined. If any of those were undefined, it'd refetch the decimals AND type.
However, for erc721 and erc1155, the decimals can be undefined. I've changed the check.