feat: introduce function to prep tx to reclaim as sender #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Live tests failed. Please check the logs to see which checks failed. |
Hugo0
approved these changes
Mar 1, 2024
| contractVersion = null, | ||
| }: { | ||
| depositIndex: number | ||
| provider?: ethers.providers.JsonRpcProvider // TODO: update to not use ethers.providers.JsonRpcProvider but just a url |
src/index.ts
Outdated
| } | ||
|
|
||
| if (contractVersion == null) { | ||
| contractVersion = getLatestContractVersion({ chainId, type: 'normal' }) |
There was a problem hiding this comment.
Unrelated, but I think we should change type naming to vault, batcher, router
Instead of normal / batch
src/index.ts
Outdated
| contractVersion = getLatestContractVersion({ chainId, type: 'normal' }) | ||
| } | ||
|
|
||
| const contract = await getContract(chainId, provider, contractVersion) |
There was a problem hiding this comment.
Unrelated, maybe we should add latest param to get Contract so we can skip this 2part thing
nebolax
reviewed
Mar 1, 2024
src/index.ts
Outdated
|
|
||
| const tx = await contract.populateTransaction.withdrawDepositSender(depositIndex) | ||
|
|
||
| const peanutUnsignedTransaction: interfaces.IPeanutUnsignedTransaction = { |
There was a problem hiding this comment.
We have ethersV5ToPeanutTx and peanutToEthersV5Tx for this kinda stuff
|
Live tests failed. Please check the logs to see which checks failed. |
2 similar comments
|
Live tests failed. Please check the logs to see which checks failed. |
|
Live tests failed. Please check the logs to see which checks failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.