-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release workflow: Add armv7 support and fix MIPS build issue #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the release workflow by adding support for the Linux ARMv7 (arm/7) architecture and fixing a build issue related to MIPS architectures.
Changes:
darwin/arm
anddarwin/386
architectures have been excluded from the build matrix, as they are not supported by macOS.wangyoucao577/go-release-action@v1
action had a bug in itsrelease.sh
script that caused a "mips: unbound variable" error. This issue has been resolved by using a forked and modified version of the action:pdahd/[email protected]
. The fix involves changing the string comparison method in the script to correctly handle MIPS architectures.Benefits:
Testing:
The updated release workflow has been tested successfully, and all supported platforms and architectures have been built and released without errors.
Recommendation:
I recommend releasing a new version of the project that includes these changes, potentially as
v1.5.4
orv1.6.0
.