Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release workflow: Add armv7 support and fix MIPS build issue #28

Merged
merged 30 commits into from
Sep 13, 2024

Conversation

pdahd
Copy link
Contributor

@pdahd pdahd commented Sep 11, 2024

This pull request improves the release workflow by adding support for the Linux ARMv7 (arm/7) architecture and fixing a build issue related to MIPS architectures.

Changes:

  • Added support for Linux ARMv7 (arm/7): This allows the project to be built and released for devices using the ARMv7 architecture, expanding its compatibility.
  • Excluded unsupported macOS architectures: The darwin/arm and darwin/386 architectures have been excluded from the build matrix, as they are not supported by macOS.
  • Fixed MIPS build issue: The original wangyoucao577/go-release-action@v1 action had a bug in its release.sh script that caused a "mips: unbound variable" error. This issue has been resolved by using a forked and modified version of the action: pdahd/[email protected]. The fix involves changing the string comparison method in the script to correctly handle MIPS architectures.

Benefits:

  • Wider platform support: The project can now be used on a wider range of devices, including those using the ARMv7 architecture.
  • Improved build reliability: The fixed MIPS build issue ensures that the release workflow runs smoothly and produces binaries for all supported platforms.

Testing:

The updated release workflow has been tested successfully, and all supported platforms and architectures have been built and released without errors.

Recommendation:

I recommend releasing a new version of the project that includes these changes, potentially as v1.5.4 or v1.6.0.
Image Description

@peanut996 peanut996 merged commit ef96fb5 into peanut996:master Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants