Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows: Drop EOL versions and added latest 1.20 #583

Merged
merged 4 commits into from
Jul 27, 2023
Merged

github/workflows: Drop EOL versions and added latest 1.20 #583

merged 4 commits into from
Jul 27, 2023

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Jul 3, 2023

  • Dropped end-of-life 1.17 and 1.18.
  • Added 1.20.

@jpds
github/workflows:
8493fc2 
- Dropped end-of-life 1.17 and 1.18.
- Added 1.20.
@jpds jpds requested a review from a team as a code owner July 3, 2023 15:59
@jpds jpds requested review from igungor and seruman and removed request for a team July 3, 2023 15:59
@seruman seruman mentioned this pull request Jul 25, 2023
Merged
@igungor
Copy link
Member

igungor commented Jul 25, 2023

There're a couple of places that needs to be updated :)

  • README: we mention that min required version is 1.17+.
  • Dockerfile: base image is 1.19-alpine. we could switch to 1.20 for Docker.
  • go.mod: minimum required Go version is 1.17.

@igungor igungor merged commit 20d6a22 into peak:master Jul 27, 2023
@igungor
Copy link
Member

igungor commented Jul 27, 2023

Thank you!

@igungor
Copy link
Member

igungor commented Jul 27, 2023

There're a couple of places that needs to be updated :)

  • README: we mention that min required version is 1.17+.
  • Dockerfile: base image is 1.19-alpine. we could switch to 1.20 for Docker.
  • go.mod: minimum required Go version is 1.17.

I'll update remaining places in a separate PR.

@igungor igungor mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seruman seruman seruman approved these changes

@igungor igungor igungor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpds @igungor @seruman