Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/url: Allow usage of adjacent slashes #459

Merged
merged 8 commits into from
Jul 22, 2022

Commits on Jul 5, 2022

  1. storage/url: Allow usage of adjacent slashes

    This commit allows url with adjacent slashes to be handled correctly.
    
    - Disabled RestProtocolURICleaning (link) as it do not allow adjacent slashes.
    - Changed path.Join method to strings.Join when joined remote urls. path.Join also cleans paths which removes additional slashes.
    - Kept local urls to be joined with path.Join.
    - Added test cases for copy;
        - Remote to local
        - Local to remote
        - Remote to remote
    - Removed redundant trailing slashes in the keys of s3 objects in ls_test.go and sync_test.go files.
    
    Fixes: peak#352 ,peak#449
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    48d0133 View commit details
    Browse the repository at this point in the history
  2. remove strings.Cut

    Replaced strings.Cut method as it is undefined before go version 1.18.x
    boraberke committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    907c23f View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Configuration menu
    Copy the full SHA
    8692e12 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Fix code review suggestions

    boraberke committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c8676a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffbe71e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Update CHANGELOG.md

    boraberke committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    8fc0836 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eee55fc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Configuration menu
    Copy the full SHA
    6785542 View commit details
    Browse the repository at this point in the history