-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage/url: Allow usage of adjacent slashes #459
Merged
Merged
Commits on Jul 5, 2022
-
storage/url: Allow usage of adjacent slashes
This commit allows url with adjacent slashes to be handled correctly. - Disabled RestProtocolURICleaning (link) as it do not allow adjacent slashes. - Changed path.Join method to strings.Join when joined remote urls. path.Join also cleans paths which removes additional slashes. - Kept local urls to be joined with path.Join. - Added test cases for copy; - Remote to local - Local to remote - Remote to remote - Removed redundant trailing slashes in the keys of s3 objects in ls_test.go and sync_test.go files. Fixes: peak#352 ,peak#449
Configuration menu - View commit details
-
Copy full SHA for 48d0133 - Browse repository at this point
Copy the full SHA 48d0133View commit details -
Replaced strings.Cut method as it is undefined before go version 1.18.x
Configuration menu - View commit details
-
Copy full SHA for 907c23f - Browse repository at this point
Copy the full SHA 907c23fView commit details
Commits on Jul 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8692e12 - Browse repository at this point
Copy the full SHA 8692e12View commit details
Commits on Jul 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c8676a7 - Browse repository at this point
Copy the full SHA c8676a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffbe71e - Browse repository at this point
Copy the full SHA ffbe71eView commit details
Commits on Jul 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8fc0836 - Browse repository at this point
Copy the full SHA 8fc0836View commit details -
Configuration menu - View commit details
-
Copy full SHA for eee55fc - Browse repository at this point
Copy the full SHA eee55fcView commit details
Commits on Jul 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6785542 - Browse repository at this point
Copy the full SHA 6785542View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.