Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add profile flag #453

Merged
merged 17 commits into from
Jul 19, 2022
Merged

storage: add profile flag #453

merged 17 commits into from
Jul 19, 2022
+116 −3

Conversation

kucukaslan
Copy link
Contributor

@kucukaslan kucukaslan commented Jun 29, 2022 •
edited
Loading

This commit adds --profile flag to allow users to specify a named profile rather than using the default.

Fixes #353

@kucukaslan kucukaslan added this to the v2.1.0 milestone Jun 29, 2022
@kucukaslan kucukaslan requested a review from a team as a code owner June 29, 2022 11:18
@kucukaslan kucukaslan requested review from aykutfarsak and ilkinulas and removed request for a team June 29, 2022 11:18
ilkinulas
ilkinulas reviewed Jul 6, 2022
View reviewed changes
command/app.go Outdated Show resolved Hide resolved
@kucukaslan
Fix typo.
22d922b 
"profile" is incompatible with "no-sign-request".
igungor
igungor reviewed Jul 7, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
command/app.go Outdated Show resolved Hide resolved
aykutfarsak
aykutfarsak reviewed Jul 7, 2022
View reviewed changes
storage/s3_test.go Outdated Show resolved Hide resolved
seruman
seruman reviewed Jul 7, 2022
View reviewed changes
storage/s3.go Outdated Show resolved Hide resolved
@kucukaslan
delete the redundant comment
923d736 
The comment just just repeats what code says.
@kucukaslan
add credential-file flag to allow users to specify credential file to…
0cbcedc 
… read credentials from.

This commit adds credential-file flag to allow users to specify credential file to read credentials from rather than using the default.

See also [Configuration and credential file settings](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html)

Updates #453.
@kucukaslan
Copy link
Contributor Author

kucukaslan commented Jul 7, 2022 •
edited
Loading

I've created a new branch based on add-profile-flag branch to add credential-file global flag to s5cmd.

If you agree I can merge it to this branch and complete them in same branch (and in this PR). Alternatively, we can merge "add-profile-flag" branch to master, and then start another PR for add-credential-file-flag branch.

Also, as I said earlier, we can write more extensive tests for profile flag when we added credential-file flag.

@aykutfarsak
Copy link
Contributor

@kucukaslan could you add --credential-file changes to readme and changelog, please?

ilkinulas
ilkinulas reviewed Jul 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ilkinulas
ilkinulas reviewed Jul 18, 2022
View reviewed changes
command/app.go Outdated Show resolved Hide resolved
@kucukaslan
Change flag name to --credentials-file, add alias --cf.
d175c29 
Previous name of flag was --credential-file and it didn't have any aliases.
Also consistently refer to the file as `credentials file`.
@kucukaslan
Copy link
Contributor Author

The tests for macos are canceled with GitHub Actions has encountered an internal error when running your job. error. Might be related to this incident.

igungor
igungor reviewed Jul 18, 2022
View reviewed changes
command/app.go Outdated Show resolved Hide resolved
@igungor igungor merged commit 717bf5b into peak:master Jul 19, 2022
@yermulnik
Copy link

👍🏻 Thank you
What's approx ETA on releasing this?

@kucukaslan kucukaslan deleted the add-profile-flag branch July 21, 2022 10:52
@igungor
Copy link
Member

igungor commented Jun 19, 2023

@yermulnik v2.1.0 is released with --profile support.

@igungor igungor mentioned this pull request Jun 19, 2023
Closed
@yermulnik
Copy link

@igungor Could you please take a look at #553 (comment) + #571 ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkinulas ilkinulas ilkinulas approved these changes

@seruman seruman seruman approved these changes

@aykutfarsak aykutfarsak aykutfarsak approved these changes

@igungor igungor igungor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
s5cmd
Archived in project
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

[Feature request] Support for "--profile" global cmdline option
6 participants
@kucukaslan @aykutfarsak @yermulnik @igungor @ilkinulas @seruman