Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sync command flags #409

Merged
merged 23 commits into from
Mar 25, 2022
Merged

Add missing sync command flags #409

merged 23 commits into from
Mar 25, 2022

Conversation

sonmezonur
Copy link
Member

@sonmezonur sonmezonur commented Feb 21, 2022

Resolves #3, resolves #365, fixes #397, fixes #416

Adding missing flags and following changes:

  • sync command can use same validation methods with cp. Currently, it does not accept single object sync and other validation logic is exactly the same with cp command. I don't see any reason for not supporting this:
sync s3://bucket/source.go .
  • Updated givenCommand() method to add flags to command string.

  • Added e2e tests for --exclude, --raw and --no-follow-symlinks and unit tests for other flags

  • Below flags are not tested:

sse
sse-kms-key-id
acl
cache-control
expires
force-glacier-transfer

@sonmezonur sonmezonur requested a review from a team as a code owner February 21, 2022 14:21
@sonmezonur sonmezonur requested review from igungor and aykutfarsak and removed request for a team February 21, 2022 14:21
e2e/sync_test.go Outdated Show resolved Hide resolved
@sonmezonur
Copy link
Member Author

PTAL. All copy flags should work with sync. Added tests

@gvreddy579
Copy link

gvreddy579 commented Mar 16, 2022

👍
I'm early waiting for this changes to be merged and an official next version release

@sonmezonur sonmezonur merged commit b43df69 into master Mar 25, 2022
@sonmezonur sonmezonur deleted the sync_missing_flags branch March 25, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants