all: enable -race flag for tests
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `run` command iterates over the commands list, where each item is a pointer to the command. `urfave/cli` packages implicitly adds `-h` flag to each command, which introduces data race because `s5cmd` executes them in parallel. Fixes #301
Below change will slowdown the tests quite a lot. Let's see the numbers first, then we can think of a solution if necessary. Fix #329 ```patch --- a/e2e/util_test.go +++ b/e2e/util_test.go @@ -186,6 +186,7 @@ func goBuildS5cmd() func() { cmd := exec.Command( "go", "build", "-mod=vendor", + "-race", "-o", s5cmdPath, ) ```
Found an open ticket: golang/go#22553 |
|
Tests finish around 5 minutes on each race-enabled platforms. Overall CI checks finished about in 32 minutes. It's bad, though I've found the bottleneck. https://gist.github.com/igungor/49f42e6cf457c309a85a26c9e18c56f6 |
igungor
requested review from
ilkinulas and
sonmezonur
and removed request for
a team
|
@ilkinulas @sonmezonur PTAL. |
ilkinulas
approved these changes
Aug 11, 2021
sonmezonur
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below change will slowdown the tests quite a lot. Let's see the numbers
first, then we can think of a solution if necessary.
Fix #329