command/run: fix concurrent writes to the flags list #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `run` command iterates over the commands list, where each item is a pointer to the command. `urfave/cli` packages implicitly adds `-h` flag to each command, which introduces data race because `s5cmd` executes them in parallel. Fixes #301
sonmezonur
approved these changes
Aug 3, 2021
|
@aykutfarsak ping |
aykutfarsak
approved these changes
Aug 5, 2021
|
Would you mind cutting a release containing this fix? I'd love to pull it in and re-try the code paths we'd disabled due to #301, and it would be easier for me to do so with a release. |
We've released v1.4.0-rc.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runcommand iterates over the commands list, where each item is apointer to the command.
urfave/clipackages implicitly adds-hflagto each command, which introduces data race because
s5cmdexecutesthem in parallel.
Fixes #301