Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'remove bucket' feature #310

Merged
merged 7 commits into from
Jul 5, 2021
Merged

Implement 'remove bucket' feature #310

merged 7 commits into from
Jul 5, 2021

Conversation

ocakhasan
Copy link
Contributor

@ocakhasan ocakhasan commented Jul 2, 2021

Resolves #303

@ocakhasan ocakhasan marked this pull request as ready for review July 2, 2021 13:57
@ocakhasan ocakhasan requested a review from a team as a code owner July 2, 2021 13:57
@ocakhasan ocakhasan requested review from igungor and ilkinulas and removed request for a team July 2, 2021 13:57
e2e/rb_test.go Outdated Show resolved Hide resolved
Co-authored-by: İlkin Balkanay <[email protected]>
command/rb.go Show resolved Hide resolved
command/rb.go Outdated Show resolved Hide resolved
command/rb.go Outdated Show resolved Hide resolved
command/rb.go Outdated Show resolved Hide resolved
command/rb.go Outdated Show resolved Hide resolved
e2e/rb_test.go Outdated Show resolved Hide resolved
e2e/rb_test.go Outdated Show resolved Hide resolved
e2e/rb_test.go Outdated Show resolved Hide resolved
e2e/rb_test.go Outdated Show resolved Hide resolved
@igungor igungor changed the title remove bucket feature. Implement 'remove bucket' feature Jul 5, 2021
@igungor
Copy link
Member

igungor commented Jul 5, 2021

solves issue #303

We mostly use Resolves #NUMBER or Fixes #NUMBER.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

e2e/rb_test.go Show resolved Hide resolved
e2e/rb_test.go Outdated Show resolved Hide resolved
e2e/rb_test.go Show resolved Hide resolved
@igungor igungor merged commit 5495dd4 into peak:master Jul 5, 2021
@igungor
Copy link
Member

igungor commented Jul 5, 2021

Congrats on your first commit 🎉

@ocakhasan ocakhasan deleted the remove branch August 2, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add remove bucket command
3 participants