Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign region detection #320

Closed
ilkinulas opened this issue Jul 12, 2021 · 1 comment · Fixed by #331
Closed

Redesign region detection #320

ilkinulas opened this issue Jul 12, 2021 · 1 comment · Fixed by #331
Labels
regression
Milestone
v2.0.0

Comments

@ilkinulas
Copy link
Member

We are using the following information to detect bucket region:

  • AWS_REGION environtment variable
  • --source-region and --destination-region options
  • Region value returned from head bucket request

Document how and in which order s5cmd uses these values.
@igungor igungor mentioned this issue Jul 29, 2021
Closed
@seruman seruman mentioned this issue Jul 29, 2021
Merged
@ilkinulas ilkinulas added this to the v2.0.0 milestone Sep 20, 2021
This was referenced Sep 20, 2021
Closed
Closed
@seruman
Copy link
Member

seruman commented Sep 20, 2021

Currently auto-region detection would always overrides the region in SDK config and causing us to ignore region given with AWS_REGION/AWS_DEFAULT_REGION environment variables or defined in given profile with AWS_PROFILE environment variable.

This causing issues with S3 compatible services returning empty response to HeadBucket request; which we used to detect bucket's region. #325, #354

#331 makes changes to address this issue.

igungor pushed a commit that referenced this issue Sep 30, 2021
@seruman
storage/s3: fix precedence of region detection (#331)
6fac3f1 
Co-authored-by: Aykut Farsak <[email protected]>

This PR makes changes to predecense of region detection as below;

```
1. --source-region or --destination-region flags of cp command.
2. AWS_REGION environment variable.
3. Region section of AWS profile.
4. Auto detection from bucket region (via HeadBucket).
5. us-east-1 as default region.
```

Resolves #325, resolves #320.

Closes #317.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

storage/s3: fix precedence of region detection peak/s5cmd
3 participants
@ilkinulas @seruman @boraberke