Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-608) Fix package url for v0.102.0 & v0.103.0 #609

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Oct 6, 2022

  1. (peaceirisGH-608) Fix package url for v0.102.0 & v0.103.0

    Prior to this change, the URL building for versions of hugo was
    deterministic as the URLs for the packages were set to a
    project-specific standard. That URL creation began to fail for macOS in
    [0.102.0] and for Windows in [0.103.0]. It does not fail for Linux
    because the hugo releases for Linux continue to include the old package
    naming as an alias.
    
    This change:
    
    - Updates the `get-os` function to take the hugo version as additional
      input, altering the return value based on the version.
    - Updates the `get-arch` function to take the operating system name and
      hugo version as additional input, altering the return value based on
      both. Including the OS name is required for handling macOS.
    - Fixes peaceiris#608
    - Fixes peaceiris#605
    
    [0.102.0]: https://github.com/gohugoio/hugo/releases/tag/v0.102.0
    [0.103.0]: https://github.com/gohugoio/hugo/releases/tag/v0.103.0
    michaeltlombardi committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e70fd02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7d0025 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. (peaceirisGH-608) Add getConventions and refactor

    This commit introduces the getConventions function, which does a one-time calculation
    for the changes in packaging conventions to propagate to the getArch and getOS
    functions.
    
    It updates those functions and the installer code to leverage the conventions.
    
    Finally, it updates the test arrangement for getArch and getOS to use test cases
    instead of repeating the same test over and over and adds unit tests for the new
    getConventions function.
    michaeltlombardi committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    b7e8a5b View commit details
    Browse the repository at this point in the history