Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance log message #383

Merged
merged 4 commits into from
Jul 8, 2020
Merged

feat: enhance log message #383

merged 4 commits into from
Jul 8, 2020

Conversation

peaceiris
Copy link
Owner

@peaceiris peaceiris commented Jul 8, 2020 •
edited
Loading

Close #359

@peaceiris
feat: add warning deploy_key on windows-latest
4e9753a 
Currently, the deploy_key option is not supported on the windows-latest.

Related #87
@codecov
Copy link

codecov bot commented Jul 8, 2020 •
edited
Loading

Codecov Report

Merging #383 into master will decrease coverage by 0.24%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   58.33%   58.09%   -0.25%     
==========================================
  Files           4        4              
  Lines         240      241       +1     
  Branches       43       43              
==========================================
  Hits          140      140              
- Misses        100      101       +1
Impacted Files Coverage Δ
src/set-tokens.ts 42.46% <50.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cdbe5...50a1923. Read the comment docs.

@peaceiris peaceiris changed the title feat: add warning deploy_key on windows-latest feat: enhance log message Jul 8, 2020
@peaceiris peaceiris merged commit 2e97684 into master Jul 8, 2020
@peaceiris peaceiris deleted the issue-359 branch July 8, 2020 20:15
peaceiris pushed a commit that referenced this pull request Jul 8, 2020
@github-actions
feat: enhance log message (#383)
b477c89 
Add warning deploy_key on windows-latest
- Currently, the deploy_key option is not supported on the windows-latest.
- Related #87

Close #359
Davidrami12
Davidrami12 reviewed Jun 14, 2023
View reviewed changes
Copy link

@Davidrami12 Davidrami12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidrami12 Davidrami12 Davidrami12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance log messages
2 participants
@peaceiris @Davidrami12