Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feat: add back candidate.build() for backward-compatibility #2750

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #2747

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.06%. Comparing base (397d9b0) to head (486cd53).

Files Patch % Lines
src/pdm/models/candidates.py 72.72% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2750      +/-   ##
==========================================
- Coverage   85.06%   85.06%   -0.01%     
==========================================
  Files         106      106              
  Lines       10556    10569      +13     
  Branches     2293     2297       +4     
==========================================
+ Hits         8979     8990      +11     
  Misses       1103     1103              
- Partials      474      476       +2     
Flag Coverage Δ
unittests 84.84% <76.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit ba7be74 into main Mar 30, 2024
20 of 21 checks passed
@frostming frostming deleted the frostming/issue2747 branch March 30, 2024 11:16
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm 2.13.x + pdm-wheel: [TypeError]: expected str, bytes or os.PathLike object, not CachedPackage
1 participant