Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install python using pbs-installer #2721

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
@pawamoy
Copy link
Contributor

pawamoy commented Mar 26, 2024

Whew, amazing!

Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 91.94631% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 84.99%. Comparing base (d50654d) to head (76d1278).
Report is 2 commits behind head on main.

Files Patch % Lines
src/pdm/cli/commands/python.py 93.54% 4 Missing and 2 partials ⚠️
src/pdm/project/core.py 84.84% 1 Missing and 4 partials ⚠️
src/pdm/cli/commands/venv/backends.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
+ Coverage   84.89%   84.99%   +0.10%     
==========================================
  Files         105      106       +1     
  Lines       10414    10537     +123     
  Branches     2271     2288      +17     
==========================================
+ Hits         8841     8956     +115     
- Misses       1101     1105       +4     
- Partials      472      476       +4     
Flag Coverage Δ
unittests 84.77% <91.27%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit ca0a27a into main Mar 27, 2024
21 checks passed
@frostming frostming deleted the feat/install-python branch March 27, 2024 02:10
@j178 j178 mentioned this pull request Apr 3, 2024
@anentropic
Copy link

apart from manually installing pythons via pdm python install can this auto install the project's required version from pyproject.toml when you do pdm install on a freshly checked out project?

@frostming
Copy link
Collaborator Author

apart from manually installing pythons via pdm python install can this auto install the project's required version from pyproject.toml when you do pdm install on a freshly checked out project?

Yes if no matching python interpreter can be found

@anentropic
Copy link

nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants