Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete setup.cfg, move tool configurations under it to pyproject.toml #2711

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

boholder
Copy link
Contributor

@boholder boholder commented Mar 21, 2024

Close #2703

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
    - [ ] Test cases added for changed code. N/A

Describe what you have changed in this PR.

As said in #2703, the goal is to removesetup.cfg file (and makes the tool configuration a little bit cleaner).

Result of pdm lint only shows two Windows special falsely positives (I'm working on a Windows PC) (because os module of cpython on windows do not have uname API):

***\pdm>pdm lint
pyupgrade................................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
codespell................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src\pdm\environments\base.py:173: error: Module has no attribute "uname"; maybe "name"?  [attr-defined]
src\pdm\environments\base.py:182: error: Module has no attribute "uname"; maybe "name"?  [attr-defined]
Found 2 errors in 1 file (checked 111 source files)

I'm not sure how to test coverage config, let's see the bot's result.

@frostming
Copy link
Collaborator

frostming commented Mar 21, 2024

Pre-commit linters are happy. But please fix the reference of setup.cfg in ci.yml

Also please add a news fragment under news/

@boholder
Copy link
Contributor Author

But please fix the reference of setup.cfg in ci.yml

Also please add a news fragment under news/

Yep, now I see where is wrong, will working on it.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (9746780) to head (235a51d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2711      +/-   ##
==========================================
+ Coverage   84.80%   84.83%   +0.02%     
==========================================
  Files         104      104              
  Lines       10294    10325      +31     
  Branches     2236     2243       +7     
==========================================
+ Hits         8730     8759      +29     
- Misses       1092     1094       +2     
  Partials      472      472              
Flag Coverage Δ
unittests 84.61% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boholder
Copy link
Contributor Author

boholder commented Mar 21, 2024

FYI here is a CI failure on my own workflow running in (3.10, windows-latest, pip, x64):
Is this a concurrency bug?
Yeah this occurs again on (3.9, windows-latest, pip, x64) combination under this PR...

@frostming frostming merged commit 93cd081 into pdm-project:main Mar 22, 2024
21 checks passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tool configurations under setup.cfg to pyproject.toml
2 participants