Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to httpx client #2709

Merged
merged 1 commit into from
Mar 21, 2024
Merged

refactor: switch to httpx client #2709

merged 1 commit into from
Mar 21, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 75.78947% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 84.77%. Comparing base (fdefbe2) to head (95e72b7).

Files Patch % Lines
src/pdm/models/repositories.py 37.83% 20 Missing and 3 partials ⚠️
src/pdm/environments/base.py 65.21% 3 Missing and 5 partials ⚠️
src/pdm/cli/commands/publish/__init__.py 42.85% 2 Missing and 2 partials ⚠️
src/pdm/models/candidates.py 55.55% 2 Missing and 2 partials ⚠️
src/pdm/cli/commands/publish/repository.py 90.00% 2 Missing and 1 partial ⚠️
src/pdm/models/session.py 95.83% 1 Missing and 1 partial ⚠️
src/pdm/models/caches.py 88.88% 1 Missing ⚠️
src/pdm/pytest.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
- Coverage   84.83%   84.77%   -0.07%     
==========================================
  Files         104      104              
  Lines       10326    10304      -22     
  Branches     2242     2237       -5     
==========================================
- Hits         8760     8735      -25     
- Misses       1096     1097       +1     
- Partials      470      472       +2     
Flag Coverage Δ
unittests 84.55% <75.78%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 242b2eb into main Mar 21, 2024
19 of 21 checks passed
@frostming frostming deleted the feat/httpx branch March 21, 2024 05:04
frostming added a commit that referenced this pull request Mar 21, 2024
@deronnax
Copy link
Contributor

what is the rational behind this move?

@frostming
Copy link
Collaborator Author

@deronnax
Copy link
Contributor

deronnax commented Mar 21, 2024

Thank you. TLDR for people: despite its fame, Requests has significant internal technical debt, is tedious to use for advanced use-cases and can't realistically be refactored and will probably never be.

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants