Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expand user path for venv.location and possibly other config keys. #2691

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #2672

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (a0cc415) to head (38d102a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         104      104           
  Lines       10309    10309           
  Branches     2237     2237           
=======================================
  Hits         8743     8743           
  Misses       1096     1096           
  Partials      470      470           
Flag Coverage Δ
unittests 84.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming changed the title feat: Expand user path for venv.location and possibly other config keys. fix: Expand user path for venv.location and possibly other config keys. Mar 14, 2024
@frostming frostming merged commit d4a13c5 into main Mar 14, 2024
21 checks passed
@frostming frostming deleted the frostming/issue2672 branch March 14, 2024 09:55
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand user path for venv.location and possibly other config keys.
1 participant