Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to exclude optional groups from install/sync -G:all #2655

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Option to exclude optional groups from install/sync -G:all #2655

merged 3 commits into from
Feb 28, 2024

Conversation

elramen
Copy link
Contributor

@elramen elramen commented Feb 28, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Added a flag, --without, that allows users to exclude specific optional groups when running pdm install/sync -G:all, e.g. pdm install -G:all --without myGroup1,myGroup2.

Added alias --with for -G/--group.

Closes #2258

@frostming
Copy link
Collaborator

Hi, I prefer --without as the option name, and we may add --with as an alias of --group/-G as well.

@elramen
Copy link
Contributor Author

elramen commented Feb 28, 2024

Hi, I prefer --without as the option name, and we may add --with as an alias of --group/-G as well.

Done! :) @frostming

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (429df86) to head (43cb794).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   84.68%   84.69%           
=======================================
  Files         104      104           
  Lines       10279    10282    +3     
  Branches     2234     2234           
=======================================
+ Hits         8705     8708    +3     
  Misses       1102     1102           
  Partials      472      472           
Flag Coverage Δ
unittests 84.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 29a081f into pdm-project:main Feb 28, 2024
21 checks passed
@frostming
Copy link
Collaborator

🎉 Cheers. PR merged

@2e0byo
Copy link
Contributor

2e0byo commented Feb 28, 2024

@elramen amazing, thank you very much.

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opting-out from optional groups
3 participants