Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_request.md: Change the template name to "Feature / Enhancement Request" #2508

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

noamraph
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Change the issue template name from "feature request" to "feature / enhancement request", since some enhancements aren't new features.

@@ -1,12 +1,12 @@
---
name: Feature request
name: Feature / Enhancement Request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/request/proposal/g

better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much better!

(I left the "request" from "feature request", but as it's not only for features, it's not for requests!)

(Although I guess there are two meanings for "request": to demand something, and to ask for it. But "proposal" is better)

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frostming frostming merged commit e188ea2 into pdm-project:main Dec 19, 2023
1 check passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants