feat: Show subcommand's help info when passing unrecognized arguments #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
+ Coverage 84.56% 84.57% +0.01%
==========================================
Files 104 104
Lines 10293 10300 +7
Branches 2248 2249 +1
==========================================
+ Hits 8704 8711 +7
Misses 1116 1116
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostming
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
When passing unrecognized arguments to a pdm subcommand, pdm displays its own help info instead of the subcommand's one. It would be more helpful for users if pdm could display the help info of the subcommand.
This issue is caused by a known design of Python's argparse module, and the argparse module is not planning to improve it. (Refs: python/cpython#83287 )
I found a modification on Stackoverflow, which I tried and found to be effective. (Refs: https://stackoverflow.com/a/61724607 )