Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inplace update #2427

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix: inplace update #2427

merged 3 commits into from
Nov 23, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <[email protected]>
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (837e7d0) 84.45% compared to head (919e464) 84.45%.

Files Patch % Lines
src/pdm/installers/manager.py 81.25% 3 Missing ⚠️
src/pdm/installers/uninstallers.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2427      +/-   ##
==========================================
- Coverage   84.45%   84.45%   -0.01%     
==========================================
  Files         102      102              
  Lines       10125    10155      +30     
  Branches     2225     2228       +3     
==========================================
+ Hits         8551     8576      +25     
- Misses       1096     1100       +4     
- Partials      478      479       +1     
Flag Coverage Δ
unittests 84.23% <93.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit 62ceee3 into main Nov 23, 2023
23 of 24 checks passed
@frostming frostming deleted the fix/inplace-update branch November 23, 2023 10:21
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm install in a venv might kill itself due to dependencies
1 participant