Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forbid global project in conda base env #2410

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Close #2409

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (73651b7) 84.51% compared to head (406727b) 84.52%.

Files Patch % Lines
src/pdm/project/core.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2410   +/-   ##
=======================================
  Coverage   84.51%   84.52%           
=======================================
  Files         102      102           
  Lines       10109    10113    +4     
  Branches     2224     2224           
=======================================
+ Hits         8544     8548    +4     
  Misses       1087     1087           
  Partials      478      478           
Flag Coverage Δ
unittests 84.30% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 20d7a65 into main Nov 16, 2023
23 checks passed
@frostming frostming deleted the fix/conda-global branch November 16, 2023 03:59
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm removes conda
1 participant