Issues 2360 (#1) #2402
Merged
Issues 2360 (#1) #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bugfix: #2360
pawamoy
reviewed
Nov 14, 2023
pawamoy
reviewed
Nov 14, 2023
pawamoy
reviewed
Nov 14, 2023
for more information, see https://pre-commit.ci
frostming
reviewed
Nov 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.01%
==========================================
Files 102 102
Lines 10096 10109 +13
Branches 2223 2224 +1
==========================================
+ Hits 8534 8544 +10
- Misses 1085 1087 +2
- Partials 477 478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostming
reviewed
Nov 14, 2023
* bugfix: #2360
|
Fine, can you please add a news fragment under |
It is completed. Thank you for your patient guidance and assistance.～～ |
frostming
approved these changes
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
Fix bugs mentioned in #2360, do some check before init a project, follow PEP 426 and sanitize the default name by replacing the illegal characters