refactor: Recursively look for the project root #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xulongwu4
force-pushed
the
find-pypackages-directory
branch
3 times, most recently
from
35c9c82 to
616119c
Compare
xulongwu4
force-pushed
the
find-pypackages-directory
branch
from
616119c to
57917d3
Compare
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
frostming
approved these changes
Sep 29, 2023
frostming
requested changes
Sep 29, 2023
|
Added a news fragment |
|
Well done, @xulongwu4 ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
This PR refactors the
find_project_root()andfind_pypackage()functions so that they now recursively looks for thepyproject.tomlfile or the__pypackages__/{version}/libdirectory in the current directory or its parent directory. This means that we no longer need to set an upper limit on the number of levels we tranverse in such a search, and thePDM_PROJECT_MAX_DEPTHenvironment variable and theproject_max_depthsetting is no longer useful.