Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --no-lock doesn't work #2250

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: --no-lock doesn't work #2250

merged 1 commit into from
Sep 11, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2245

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #2245

Signed-off-by: Frost Ming <[email protected]>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/pdm/cli/commands/update.py ø
src/pdm/cli/actions.py 100.00%
src/pdm/cli/commands/add.py 100.00%
src/pdm/cli/commands/install.py 100.00%
src/pdm/cli/commands/remove.py 100.00%
src/pdm/cli/options.py 100.00%
src/pdm/installers/synchronizers.py 100.00%
src/pdm/project/core.py 100.00%

📢 Thoughts on this report? Let us know!.

@frostming frostming merged commit 79c82c5 into main Sep 11, 2023
@frostming frostming deleted the frostming/issue2245 branch September 11, 2023 01:16
@pawamoy
Copy link
Contributor

pawamoy commented Sep 11, 2023

How does this fix work? What will rm pdm.lock; pdm install --no-lock do now?

@pawamoy
Copy link
Contributor

pawamoy commented Sep 11, 2023

Looks to me like --no-lock was removed from the install command, and a new PDM_NO_LOCK environment variable was introduced.

@frostming
Copy link
Collaborator Author

--no-lock does exist, when this option is on, pdm.lock won't be touched. All resolution steps, if needed, are performed in memory and no write happens.

@pawamoy
Copy link
Contributor

pawamoy commented Sep 11, 2023

I see, super nice, thanks for the explanation 👍

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm install --no-lock fails in the absence of lock file
2 participants