Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell detection failure #2188

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

pgarrison
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Now, if pdm venv activate fails to identify the shell (as it did with my zsh setup) it will use the default behavior instead of crashing.

Fixes #2187

@pgarrison pgarrison changed the title Fix/shell detection failure Fix shell detection failure Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (79a56a7) 84.27% compared to head (1d42c4c) 84.27%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2188   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         100      100           
  Lines        9786     9786           
  Branches     2161     2161           
=======================================
  Hits         8247     8247           
  Misses       1065     1065           
  Partials      474      474           
Flag Coverage Δ
unittests 84.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pdm/cli/commands/venv/activate.py 92.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 7582b92 into pdm-project:main Aug 17, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm venv activate: ShellDetectionFailure
3 participants