Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The cache collision issue between named requirements and url requirements #2067

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2064

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (105221a) 84.51% compared to head (102170a) 84.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2067      +/-   ##
==========================================
+ Coverage   84.51%   84.53%   +0.01%     
==========================================
  Files         100      100              
  Lines        9616     9626      +10     
  Branches     2104     2106       +2     
==========================================
+ Hits         8127     8137      +10     
  Misses       1033     1033              
  Partials      456      456              
Flag Coverage Δ
unittests 84.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/caches.py 88.42% <100.00%> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 2339fd3 into main Jun 29, 2023
@frostming frostming deleted the frostming/issue2064 branch June 29, 2023 02:03
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lockfile does not always respect correct dependencies when installing from VCS
2 participants