Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PYTHONDEVMODE=1 for CI #2004

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

sanmai-NL
Copy link
Contributor

@sanmai-NL sanmai-NL commented Jun 12, 2023

See https://docs.python.org/3/library/devmode.html. This helps to detect issues like #1988 earlier.

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

The title and commit message say it.

I‘m using this setting in CI pipelines everywhere and I have only good experiences with it.

(Please explain whether the two checklist items need completion in this case.)

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (5c47426) 85.24% compared to head (cde08e9) 85.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
- Coverage   85.24%   85.22%   -0.03%     
==========================================
  Files          99       99              
  Lines        9367     9367              
  Branches     2042     2042              
==========================================
- Hits         7985     7983       -2     
- Misses        937      939       +2     
  Partials      445      445              
Flag Coverage Δ
unittests 85.02% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit fe83a75 into pdm-project:main Jun 12, 2023
@sanmai-NL
Copy link
Contributor Author

@frostming Based on the CI output for the test, unless I missed something, PYTHONDEVMODE=1 wouldn't have caught #1988. Only if you test PDM by invoking the CLI, would it have caught such a problem.

@sanmai-NL sanmai-NL mentioned this pull request Jun 12, 2023
2 tasks
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants