Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing setup.py error if it outputs to stdout #1998

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #1995

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9393362) 85.22% compared to head (c4861ab) 85.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files          99       99           
  Lines        9352     9356    +4     
  Branches     2038     2039    +1     
=======================================
+ Hits         7970     7974    +4     
  Misses        938      938           
  Partials      444      444           
Flag Coverage Δ
unittests 85.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/in_process/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 328ca5b into main Jun 11, 2023
@frostming frostming deleted the frostming/issue1995 branch June 11, 2023 03:28
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue with parsing setup.py (pdm.models.in_process.parse_setup_py)
2 participants