Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guess name from the VCS url when importing requirements (#1970) #1976

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

frostming
Copy link
Collaborator

Fix #1970

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage: 65.90% and project coverage change: -0.08 ⚠️

Comparison is base (7bc5d7a) 85.23% compared to head (600a96c) 85.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   85.23%   85.16%   -0.08%     
==========================================
  Files          99       99              
  Lines        9271     9294      +23     
  Branches     2023     2030       +7     
==========================================
+ Hits         7902     7915      +13     
- Misses        928      936       +8     
- Partials      441      443       +2     
Flag Coverage Δ
unittests 84.95% <65.90%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/repositories.py 73.53% <50.00%> (-0.33%) ⬇️
src/pdm/models/requirements.py 91.16% <66.66%> (-1.93%) ⬇️
src/pdm/formats/requirements.py 78.62% <100.00%> (+0.60%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit c02dcb9 into main Jun 5, 2023
@frostming frostming deleted the frostming/issue1970 branch June 5, 2023 04:42
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm lock & pdm install on git dependencies
2 participants