Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting case sensitivity in list command (#1973) #1974

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

dbalabka
Copy link
Contributor

@dbalabka dbalabka commented Jun 4, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixed #1973

@frostming
Copy link
Collaborator

@dbalabka Can you fix the failing tests?

@dbalabka
Copy link
Contributor Author

dbalabka commented Jun 5, 2023

@frostming, yes sure. I'm in progress

src/pdm/cli/commands/list.py Outdated Show resolved Hide resolved
@frostming
Copy link
Collaborator

You fix makes sense but it seems can't work with the test suite due to the mocking.

I will remove the test change and merge.

Signed-off-by: Frost Ming <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (16a137f) 85.24% compared to head (013c288) 85.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   85.24%   85.22%   -0.03%     
==========================================
  Files          99       99              
  Lines        9367     9367              
  Branches     2042     2042              
==========================================
- Hits         7985     7983       -2     
- Misses        937      939       +2     
  Partials      445      445              
Flag Coverage Δ
unittests 85.02% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/list.py 91.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit c6b5f3b into pdm-project:main Jun 12, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDM list command sorts by name is case sensitive manner
4 participants