Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use install cache when installing build requirements to avoid race condition #1943

Merged
merged 1 commit into from
May 22, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #1869

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (df0013f) 85.15% compared to head (f283354) 85.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1943   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files          99       99           
  Lines        9254     9256    +2     
  Branches     2015     2016    +1     
=======================================
+ Hits         7880     7882    +2     
  Misses        939      939           
  Partials      435      435           
Flag Coverage Δ
unittests 84.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/core.py 100.00% <ø> (ø)
src/pdm/cli/commands/install.py 89.13% <100.00%> (ø)
src/pdm/installers/synchronizers.py 84.87% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 37886fb into main May 22, 2023
@frostming frostming deleted the frostming/issue1869 branch May 22, 2023 04:40
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install cache is not concurrent-proof - errors on parallel executions
2 participants