Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract the logic about virtualenv to its own module #1889

Merged
merged 1 commit into from
May 6, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #1866

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 82.07% and project coverage change: -0.03 ⚠️

Comparison is base (c2178ce) 85.45% compared to head (99feda8) 85.43%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   85.45%   85.43%   -0.03%     
==========================================
  Files          99      100       +1     
  Lines        9098     9133      +35     
  Branches     1963     1970       +7     
==========================================
+ Hits         7775     7803      +28     
- Misses        893      899       +6     
- Partials      430      431       +1     
Flag Coverage Δ
unittests 85.25% <82.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/environments/python.py 80.64% <25.00%> (-3.23%) ⬇️
src/pdm/models/candidates.py 86.68% <25.00%> (-0.48%) ⬇️
src/pdm/cli/commands/venv/list.py 87.50% <50.00%> (ø)
src/pdm/cli/commands/venv/remove.py 86.36% <50.00%> (ø)
src/pdm/utils.py 84.40% <50.00%> (-1.32%) ⬇️
src/pdm/cli/commands/venv/__init__.py 84.84% <83.33%> (+4.29%) ⬆️
src/pdm/models/venv.py 94.28% <94.28%> (ø)
src/pdm/cli/commands/venv/utils.py 98.07% <94.44%> (-0.17%) ⬇️
src/pdm/cli/actions.py 80.82% <100.00%> (ø)
src/pdm/cli/commands/init.py 94.52% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit ee1da21 into main May 6, 2023
@frostming frostming deleted the feat/venv-refactor branch May 6, 2023 01:36
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venv detection not working with micromamba
2 participants