Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document installing pip with ensurepip #1860

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

adriangb
Copy link
Contributor

No description provided.

@adriangb
Copy link
Contributor Author

cc @pawamoy

Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@frostming
Copy link
Collaborator

Noted that it's possible to use --with-pip when creating the venv to include a pip inside. IMO you should mention that as well.

@adriangb
Copy link
Contributor Author

Added. As far as I can tell, that was not documented anywhere else, which is a shame.

@frostming
Copy link
Collaborator

Hmm, I assume people will look for the CLI help when he wants to tweak the behavior: https://pdm.fming.dev/latest/reference/cli/#create

@frostming frostming merged commit e7cf6e0 into pdm-project:main Apr 28, 2023
@adriangb
Copy link
Contributor Author

I guess I'll blame mkdocs' search:

image

@adriangb adriangb deleted the document-add-pip branch April 28, 2023 01:12
@frostming
Copy link
Collaborator

Well, generated content may not be indexed. @pawamoy

@pawamoy
Copy link
Contributor

pawamoy commented Apr 28, 2023

Ha, maybe indeed. I'll check it out.

@pawamoy
Copy link
Contributor

pawamoy commented Apr 28, 2023

Yeah not sure what's happening with the search.

search

If I type cli virtualenv with pip instead, it doesn't find the virtualenv word. It also does not find the "with" in "--with-pip" 😕 Maybe @squidfunk's work on the search feature will improve things here 🙂

@squidfunk
Copy link

--with-pip is translated to "exclude -with-pip from search" – that's how lunr.js works. We're working on improving the situation and will ship a new, completely revamped search experience in the near future!

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants