Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor environment package #1791

Merged
merged 9 commits into from
Mar 29, 2023
Merged

refactor: Refactor environment package #1791

merged 9 commits into from
Mar 29, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 74.25% and project coverage change: +0.04 🎉

Comparison is base (2cbf80f) 85.11% compared to head (c94dec3) 85.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   85.11%   85.15%   +0.04%     
==========================================
  Files          95       99       +4     
  Lines        8914     8974      +60     
  Branches     1941     1946       +5     
==========================================
+ Hits         7587     7642      +55     
- Misses        899      906       +7     
+ Partials      428      426       -2     
Flag Coverage Δ
unittests 84.96% <74.25%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/export.py 94.87% <0.00%> (ø)
src/pdm/models/repositories.py 78.83% <ø> (ø)
src/pdm/project/toml_file.py 100.00% <ø> (ø)
src/pdm/models/candidates.py 87.20% <50.00%> (+0.29%) ⬆️
src/pdm/environments/__init__.py 60.00% <60.00%> (ø)
src/pdm/environments/local.py 66.66% <66.66%> (ø)
src/pdm/environments/base.py 70.00% <70.00%> (ø)
src/pdm/environments/python.py 77.41% <77.41%> (ø)
src/pdm/cli/commands/info.py 93.33% <80.00%> (+0.74%) ⬆️
src/pdm/project/core.py 89.38% <87.50%> (+0.23%) ⬆️
... and 16 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming added this to the Release 2.5 milestone Mar 29, 2023
@frostming frostming merged commit 146daa2 into main Mar 29, 2023
@frostming frostming deleted the new-pep582 branch March 29, 2023 03:22
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants