Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- added a check to pack pdm and at least print the version... #1665

Merged
merged 1 commit into from
Feb 3, 2023
Merged

- added a check to pack pdm and at least print the version... #1665

merged 1 commit into from
Feb 3, 2023

Conversation

franzhaas
Copy link
Contributor

@franzhaas franzhaas commented Feb 2, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

added a ci step to build a packed pdm, and print the version

the one job that fails does not use pip, so packer propably is not supported there...

please have a look.

Best regards,

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Base: 85.21% // Head: 85.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (cf2f82e) compared to base (91a500d).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
- Coverage   85.21%   85.21%   -0.01%     
==========================================
  Files          92       92              
  Lines        8563     8567       +4     
  Branches     1851     1851              
==========================================
+ Hits         7297     7300       +3     
- Misses        850      852       +2     
+ Partials      416      415       -1     
Flag Coverage Δ
unittests 85.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/utils.py 86.47% <0.00%> (-0.61%) ⬇️
src/pdm/project/core.py 88.86% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@franzhaas franzhaas marked this pull request as ready for review February 2, 2023 20:49
@frostming frostming merged commit a188032 into pdm-project:main Feb 3, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants