Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm lock --check pre-commit hook #1475

Merged

Conversation

onerandomusername
Copy link
Contributor

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

closes #1471 :)

@onerandomusername onerandomusername changed the title Feat/pdm check pre commit hook pdm lock --check pre-commit hook Oct 30, 2022
@onerandomusername
Copy link
Contributor Author

seems like pre-commit is failing for code that wasn't changed in this pull

.pre-commit-hooks.yaml Outdated Show resolved Hide resolved
docs/docs/usage/advanced.md Outdated Show resolved Hide resolved
docs/docs/usage/advanced.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 84.97% // Head: 85.19% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (70809b4) compared to base (1e5dc62).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   84.97%   85.19%   +0.21%     
==========================================
  Files          88       88              
  Lines        7662     7854     +192     
  Branches     1798     1859      +61     
==========================================
+ Hits         6511     6691     +180     
- Misses        766      776      +10     
- Partials      385      387       +2     
Flag Coverage Δ
unittests 85.00% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/list.py 91.38% <0.00%> (-8.62%) ⬇️
src/pdm/models/working_set.py 67.44% <0.00%> (-2.33%) ⬇️
src/pdm/cli/actions.py 79.46% <0.00%> (-1.05%) ⬇️
src/pdm/models/repositories.py 78.04% <0.00%> (-0.82%) ⬇️
src/pdm/termui.py 89.85% <0.00%> (-0.73%) ⬇️
src/pdm/installers/uninstallers.py 80.62% <0.00%> (+0.20%) ⬆️
src/pdm/models/requirements.py 95.10% <0.00%> (+0.30%) ⬆️
src/pdm/cli/utils.py 82.74% <0.00%> (+3.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 12cf640 into pdm-project:main Oct 31, 2022
@onerandomusername onerandomusername deleted the feat/pdm-check-pre-commit-hook branch October 31, 2022 03:22
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm check: check if the lockfile is up to date and related pre-commit hook
3 participants