Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate .pdm-python in .gitignore after pdm fix #1800

Closed
1 task done
oedokumaci opened this issue Apr 1, 2023 · 0 comments · Fixed by #1802
Closed
1 task done

Duplicate .pdm-python in .gitignore after pdm fix #1800

oedokumaci opened this issue Apr 1, 2023 · 0 comments · Fixed by #1802
Labels
🐛 bug Something isn't working

Comments

@oedokumaci
Copy link
Contributor

  • I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

Environment is such that pdm notifies config fixer and .gitignore contains the following two lines

.pdm-python
.pdm.toml

Then, run

pdm fix

Actual behavior

New contents of the .gitignore:

.pdm-python
.pdm-python

Expected behavior

New contents of the .gitignore:

.pdm-python
.pdm.toml

Note that .pdm.toml is being kept for the good measure.

Environment Information

PDM version:
  2.5.0b0
Python Interpreter:
  Python 3.10
Local Packages:
  
{
  "implementation_name": "cpython",
  "implementation_version": "3.10.10",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "22.3.0",
  "platform_system": "Darwin",
  "platform_version": "Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64",
  "python_full_version": "3.10.10",
  "platform_python_implementation": "CPython",
  "python_version": "3.10",
  "sys_platform": "darwin"
}
@oedokumaci oedokumaci added the 🐛 bug Something isn't working label Apr 1, 2023
frostming pushed a commit that referenced this issue Apr 3, 2023
* fix: avoid duplicate .pdm-python in .gitignore.
fixes #1800

* refactor: remove else block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant