PEP-8

[c4xuxo]

Changes made base PyCharm inspections, flake8 and also some feedback from pylint.

Goal was to fix as much "problems" as possible without (or with minimal) impact on code.
Some parts need refactoring and renaming of variables, methods, classes, although this was avoided (as much as possible) in this change.

Before

flake8 --count
774

PyCharm

pylint *

Your code has been rated at -2.97/10 (previous run: -2.97/10, +0.00)

After

flake8 --count
20

PyCharm

pylint *

Your code has been rated at -1.31/10 (previous run: -2.97/10, +1.65)

[pietermarsman]

Thanks for the effort!

It has been a while since you have made these changes and they are not up to date anymore with the current branch. @c4xuxo, can you look into that and fix it?

Another thing, perhaps we want to add flake8 testing to the test suite. I've experience with pytest-flakes, but perhaps there is an alternative for nose. Or just a seperate step in the testing process. @ganeshtata, what do you think about this? We could start of with a small subset of flake8 checks and increase the number over time. @c4xuxo, are you willing to implement that too?

[tataganesh]

We could start of with a small subset of flake8 checks and increase the number over time.

This is a good idea. That way, code committed will always comply to flake8.

[pietermarsman]

@c4xuxo do you have time to work on this?

I did some research on flake8 and I think we can start with a small subset that indicate bugs or errors:

• E9* - possible runtime errors
• F* - pyflake errors (e.g. undefined name)
• W*. - warnings (but ignore W5* because these are ignored by default)

So an example .flake8 could be:

[flake8]
exclude = .git,__pycache__,old,build,dist,cmaprsrc,docs,samples
select = C,E9,F,W
ignore = W50

[pietermarsman]

Hi @c4xuxo, I think it is a good idea to have some coding standards! I also have some requests. Do you have time to work on that?

[pietermarsman]

@ganeshtata, this seems to be an inactive PR. I think we should close PR's without active contributors.

[c4xuxo]

@pietermarsman eventually I will find sometime.... lets see...
It also can be close no a problem from my side.

[pietermarsman]

I'm closing this PR because it has to many merge conflicts.

I still a big fan of using pep8 guidelines or flake8 enforcement, but I think we can better start over than use this PR. Feel free to reopen if you think it will cost you less time using this existing PR.

I've created an issue so that we will not forget about it: #312