Setup scripts #42
Open
Setup scripts #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made setup scripts for TranX so it can be installed into Python environments.
I didn't find any version number other than 0.1.0 for a very old Git tag, so I used 0.2.0.
As there is no base package, the Python modules and packages will be installed into the site-packages root. It would be a good idea to move everything into a base package.
Also, I could not configure any scripts as the Python scripts under scripts/ don't use the "python -m" syntax, so they don't work outside the source tree, and all of them are named either train.sh or test.sh so there are name collisions when they are put into the environment's bin directory. I also could not use entry_points.console_scripts as exp.py doesn't have a "main" function.
If you're fine with me doing these additional changes, I can make another PR.