Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Uninstall UI enhancements #18

Merged
merged 11 commits into from
Mar 22, 2020
Merged

Conversation

nikhilogic
Copy link
Contributor

  • Added validation on Install and Uninstall buttons in the ProjectsPanel so buttons are enabled or disabled
  • Added links to quickly install and uninstall with single clicks.
  • Increased spacing between project items for clarity.
  • Added styles for disabling buttons and anchor tags.

@pcislo
Copy link
Owner

pcislo commented Mar 19, 2020

Hi, thanks for your pull request. I've noticed that there are some visual problems.

scr1

When fixed, I will be able to merge this pr.

@nikhilogic
Copy link
Contributor Author

I was not able to see that issue on my machine. tried all the vs code built-in themes as well.
anyways- I have moved the uninstall link to keep it separate from the version label. hope it make it more consistent

Copy link
Owner

@pcislo pcislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .github/workflows/blank.yml as it's not needed here and the rest is fine. Thanks for your support.

@pcislo pcislo merged commit 77619ab into pcislo:development Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants